Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(debug): add missing parentheses in ternary expression #1035

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Jan 5, 2024

Fixes #711

@sergiud sergiud added the bug label Jan 5, 2024
@sergiud sergiud added this to the 0.7 milestone Jan 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b172be9) 59.18% compared to head (96a72b1) 59.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
+ Coverage   59.18%   59.42%   +0.23%     
==========================================
  Files          19       19              
  Lines        2541     2541              
  Branches      908      908              
==========================================
+ Hits         1504     1510       +6     
+ Misses        693      686       -7     
- Partials      344      345       +1     
Files Coverage Δ
src/glog/logging.h 72.85% <ø> (ø)

... and 3 files with indirect coverage changes

@sergiud sergiud force-pushed the dcheck branch 3 times, most recently from 60f8280 to 3c5a829 Compare January 5, 2024 11:31
@sergiud sergiud merged commit 6d23649 into master Jan 5, 2024
267 of 268 checks passed
@sergiud sergiud deleted the dcheck branch January 5, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLOG_ASSERT bug for non-debug mode compilation?
2 participants